Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Support statsJson in angular schemas #29233

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 27, 2024

Closes #

What I did

this PR introduced the flag and added handling of statsJson in angular, but an important piece was missing: to update the angular schema to include that flag as well. This PR introduces it.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.4 MB 78.4 MB 0 B -0.61 0%
initSize 144 MB 144 MB 0 B -0.9 0%
diffSize 65.1 MB 65.1 MB 0 B -0.69 0%
buildSize 6.83 MB 6.83 MB 0 B -0.84 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -0.86 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.83 MB 3.83 MB 0 B -0.86 0%
buildPreviewSize 3 MB 3 MB 0 B 0.77 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.3s 6.7s -1s -640ms -1.48 🔰-24.3%
generateTime 22.4s 19s -3s -427ms -0.68 -18%
initTime 16.4s 13.3s -3s -55ms -0.92 -22.9%
buildTime 7.3s 8.5s 1.2s -0.31 14.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.4s 5.8s 372ms 0.05 6.3%
devManagerResponsive 3.3s 3.3s 4ms -0.77 0.1%
devManagerHeaderVisible 566ms 576ms 10ms 0.17 1.7%
devManagerIndexVisible 639ms 636ms -3ms -0.06 -0.5%
devStoryVisibleUncached 636ms 880ms 244ms -0.63 27.7%
devStoryVisible 637ms 634ms -3ms 0.11 -0.5%
devAutodocsVisible 508ms 494ms -14ms -0.27 -2.8%
devMDXVisible 535ms 532ms -3ms 0.25 -0.6%
buildManagerHeaderVisible 561ms 591ms 30ms 0.55 5.1%
buildManagerIndexVisible 582ms 632ms 50ms 0.91 7.9%
buildStoryVisible 560ms 592ms 32ms 0.57 5.4%
buildAutodocsVisible 502ms 512ms 10ms 0.62 2%
buildMDXVisible 412ms 496ms 84ms 0.92 16.9%

Greptile Summary

This PR adds support for the 'statsJson' option in Angular's build-storybook and start-storybook schemas, enhancing configuration options for Storybook in Angular projects.

  • Added 'statsJson' property to /code/frameworks/angular/src/builders/build-storybook/schema.json
  • Added 'statsJson' property to /code/frameworks/angular/src/builders/start-storybook/schema.json
  • Both schemas now support writing stats JSON to disk, similar to existing 'webpackStatsJson' option
  • Improves flexibility in output generation for Angular projects using Storybook

@yannbf yannbf added bug angular patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Sep 27, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Sep 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3453b86. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 13, 2024
@yannbf yannbf merged commit 8690ee9 into next Dec 13, 2024
60 checks passed
@yannbf yannbf deleted the fix/stats-json-in-angular-executor branch December 13, 2024 11:28
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants