Addon-Test: Implement Global Error Modal #29309
Conversation
valentinpalkovic
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings
| Rerun | ||
| </Button> | ||
| <Button variant="ghost" asChild> | ||
| {/* TODO: Is this the right link? */} |
There was a problem hiding this comment.
style: Remove TODO comment before merging
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 06836a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| color: theme.color.defaultText, | ||
| })); | ||
|
|
||
| const TROUBLESHOOT_LINK = `https://storybook.js.org/docs/vitest/troubleshooting`; |
There was a problem hiding this comment.
You can use this solution to figure out the correct link which includes version and renderer:
https://github.com/storybookjs/storybook/pull/29294/files#diff-b5d7f930a7ae284cca8c7b8e4dbb1cee16770206bc9cf8f1dd73f8fe6d80fd34R39-R44
And to make the stories work, you can use this:
https://github.com/storybookjs/storybook/pull/29294/files#diff-b92a3cddfcd19801bbd0ebdcb31bfdeb9348d3819bc11de65c9470b63cec5306R40
valentinpalkovic
force-pushed
the
valentin/add-global-error-modal
branch
from
feea5cd to
6670087
Compare
Relates #29312
What I did
Implemented the Global Error Modal for the Testing Addon and changed slightly the background css of the Modal component.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR implements a Global Error Modal for the Testing Addon and updates the Modal component's stories and styles. Here are the key changes:
GlobalErrorModalcomponent in/code/addons/test/src/components/GlobalErrorModal.tsxGlobalErrorModalin/code/addons/test/src/components/GlobalErrorModal.stories.tsx/code/core/src/components/components/Modal/Modal.stories.tsxwith improved visual presentation/code/core/src/components/components/Modal/Modal.styled.tsxfor better error handling@storybook/themingas a dependency in/code/addons/test/package.json