Addon Test: Integrate global error modal #29318
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2eb23c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
changed the base branch from
unified-ui-testing
to
ui-testing-progress
yannbf
force-pushed
the
valentin/integrate-global-error-modal
branch
from
ce82d9d to
11a0891
Compare
yannbf
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -23,7 +23,7 @@ export class VitestManager { | |||
|
|
|||
| this.vitest = await createVitest('test', { | |||
| watch: watchMode, | |||
| passWithNoTests: true, | |||
| passWithNoTests: false, | |||
There was a problem hiding this comment.
logic: Changing passWithNoTests to false might cause issues if there are no tests present. Consider the implications of this change on the test execution flow.
| if (this.vitest) { | ||
| this.vitest.onCancel(() => { | ||
| // TODO: handle cancelation | ||
| }); | ||
| } |
There was a problem hiding this comment.
logic: The onCancel handler is currently empty. Implement proper cancellation logic to ensure resources are cleaned up and the system is left in a consistent state.
| // TODO: This is just temporary, the UI will be different | ||
| await page.locator('#addons').getByRole('button').nth(2).click(); | ||
| await page.locator("#addons").getByRole("button").nth(2).click(); |
There was a problem hiding this comment.
style: This line is duplicated from the previous test. Consider extracting this common setup into a helper function
| const errorFilter = page.getByLabel("Show errors"); | ||
| await expect(errorFilter).toBeVisible({ timeout: 30000 }); |
There was a problem hiding this comment.
style: The timeout of 30000ms seems quite long. Consider if this can be reduced or made configurable
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR integrates a global error modal and updates test management functionality in Storybook, focusing on improved error handling and UI updates for test execution and results display.
code/core/src/types/modules/addons.tscode/core/src/manager/components/sidebar/SidebarBottom.tsxcode/addons/test/src/node/vitest-manager.tsto handle test cancellation and modify test run behavioremitChannelEventmethod from SbPage class incode/e2e-tests/util.tstest-storybooks/portable-stories-kitchen-sink/react/e2e-tests/component-testing.spec.ts, including watch mode and improved test result handling