Addon Test: Only register testing module in Vite projects #29472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| message = 'Component tests failed'; | ||
| } else if (crashed || (failed && errorMessage)) { | ||
| message = ( | ||
| if (globalThis.STORYBOOK_BUILDER?.includes('vite')) { |
There was a problem hiding this comment.
style: Consider using a more robust check like STORYBOOK_BUILDER === '@storybook/builder-vite' instead of string includes
| testResults: TestResult[]; | ||
| error?: { message: string; name: string }; | ||
| }>); | ||
| } | ||
|
|
||
| addons.add(PANEL_ID, { |
There was a problem hiding this comment.
logic: Panel is still registered even when test provider is not available, which could lead to confusing empty UI state
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a47eaf8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
valentinpalkovic
approved these changes
Oct 29, 2024
kasperpeulen
deleted the
yann/disable-testing-module-on-non-vite-projects
branch
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
The Testing module UI will now only be registered in Vite-based projects.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR modifies the test addon to conditionally enable component testing functionality only for Vite-based Storybook projects, while maintaining the UI panel for all projects.
globalThis.STORYBOOK_BUILDER?.includes('vite')incode/addons/test/src/manager.tsxto gate test provider registrationTEST_PROVIDER_IDnow only occurs for Vite projectsPANEL_IDremains available for all projects regardless of builder