Addon Test: Optimize internal dependencies #29595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
134
to
142
| config.optimizeDeps ??= {}; | ||
| config.optimizeDeps = { | ||
| ...config.optimizeDeps, | ||
| include: [ | ||
| ...config.optimizeDeps.include, | ||
| 'react-dom/test-utils', | ||
| '@storybook/experimental-addon-test/internal/test-utils', | ||
| ], | ||
| }; |
There was a problem hiding this comment.
logic: potential error if config.optimizeDeps.include is undefined - should check and initialize as empty array if needed
Comment on lines
138
to
141
| ...config.optimizeDeps.include, | ||
| 'react-dom/test-utils', | ||
| '@storybook/experimental-addon-test/internal/test-utils', | ||
| ], |
There was a problem hiding this comment.
style: check if project uses React before including react-dom/test-utils to avoid unnecessary dependencies
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 32fff17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
force-pushed
the
yann/fix-e2e-flake-discrepancy-test
branch
from
005ca03
to
f231139
Compare
yannbf
added
the
patch:yes
valentinpalkovic
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
Merged
yannbf
added a commit
that referenced
this pull request
Nov 13, 2024
…ancy-test Addon Test: Optimize internal dependencies (cherry picked from commit cb66c33)
github-actions
bot
added
the
patch:done
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
This is an effort to fix E2E test flake that in our codebase, but turned out that addon-test was missing one bit of optimization which also contributed to flake (actually to all users) so this PR fixes that too.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Based on the provided files and changes, here's a concise summary of the pull request:
Optimizes internal dependencies and test configurations for the Storybook Vitest plugin, focusing on improved dependency management and test environment handling.
react-dom/test-utilsand test utilities tooptimizeDeps.includein Vitest plugin for better dependency optimizationplaywright.config.tsto simplify local E2E testing setupAddonTest.stories.tsxto verify browser vs CLI environment behaviors