-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Test: Context menu UI #29727
Addon Test: Context menu UI #29727
Conversation
…Render component for the sidebar context menu
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9622f5c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…isallow changing settings while running tests
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
…anges, as this is jarring and not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
Fixes #29647
What I did
Updates the context menu for addon-test to provide info about each test type and allow changing settings.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR updates the test addon's context menu UI to improve test status visualization and configuration, with major changes to error handling, component organization, and status management.
GlobalErrorContext
andGlobalErrorModal
components for centralized error state management and displayTestProviderRender
to support per-story test filtering and improved status handling withstatusOrder
andstatusMap
Title
andDescription
components to improve code organization and reusability in context menu UITestStatusIcon
to include a new 'critical' status option and improved percentage-based visualizationAddon_TestProviderType
interface to includeTestProviderConfig
in state parametersThe changes appear well-structured and maintain core functionality while improving the UI and error handling capabilities. The PR includes proper type safety and follows React/TypeScript best practices.
💡 (5/5) You can turn off certain types of comments like style here!