-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.5.0-alpha.18 #29809
Conversation
…required packages for supporting coverage
…ybookjs/storybook into yann/automatic-stories-glob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Addon Test: Refactor test addon to include stories automatically
5080ad0
to
99c2ef9
Compare
Build: Add build-package invalid package name tips
99c2ef9
to
c3039e6
Compare
Build: Migrate repo to Nx 20
…ep-missing-error Addon Test: Clarify message when `vitest` detects missing deps
Revert "Build: Migrate repo to Nx 20"
c3039e6
to
a935c66
Compare
Addon Test: Replace `glob` with `tinyglobby`
a935c66
to
33b89b7
Compare
Vue: Properly resolve Vite plugin
33b89b7
to
cb2e01b
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cb2e01b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 61 | 61 | 0 |
Self size | 695 KB | 799 KB | 🚨 +104 KB 🚨 |
Dependency size | 13.86 MB | 13.86 MB | 0 B |
Bundle Size Analyzer | Link | Link |
@storybook/builder-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 223 | 223 | 0 |
Self size | 79 KB | 79 KB | 0 B |
Dependency size | 29.64 MB | 29.65 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/ember
Before | After | Difference | |
---|---|---|---|
Dependency count | 250 | 250 | 0 |
Self size | 22 KB | 22 KB | 0 B |
Dependency size | 32.04 MB | 32.05 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/html-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 233 | 233 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 30.19 MB | 30.20 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/nextjs
Before | After | Difference | |
---|---|---|---|
Dependency count | 585 | 585 | 0 |
Self size | 464 KB | 464 KB | 0 B |
Dependency size | 83.85 MB | 83.86 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/preact-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 231 | 231 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 29.76 MB | 29.77 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 309 | 309 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 40.93 MB | 40.95 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 241 | 241 | 0 |
Self size | 14 KB | 14 KB | 0 B |
Dependency size | 31.17 MB | 31.18 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/svelte-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 296 | 296 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 37.75 MB | 37.77 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/vue3-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 482 | 482 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 54.16 MB | 54.18 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/web-components-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 231 | 231 | 0 |
Self size | 5 KB | 5 KB | 0 B |
Dependency size | 29.81 MB | 29.82 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/preset-html-webpack
Before | After | Difference | |
---|---|---|---|
Dependency count | 93 | 93 | 0 |
Self size | 4 KB | 4 KB | 0 B |
Dependency size | 20.21 MB | 20.22 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
Before | After | Difference | |
---|---|---|---|
Dependency count | 182 | 182 | 0 |
Self size | 24 KB | 24 KB | 0 B |
Dependency size | 30.97 MB | 30.98 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/preset-vue3-webpack
Before | After | Difference | |
---|---|---|---|
Dependency count | 365 | 365 | 0 |
Self size | 9 KB | 9 KB | 0 B |
Dependency size | 45.09 MB | 45.10 MB | 🚨 +13 KB 🚨 |
Bundle Size Analyzer | Link | Link |
This is an automated pull request that bumps the version from
8.5.0-alpha.17
to8.5.0-alpha.18
.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.18
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:glob
withtinyglobby
#29817vitest
detects missing deps #29763If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.18
vitest
detects missing deps - #29763, thanks @ndelangen!glob
withtinyglobby
- #29817, thanks @ghengeveld!