Addon Test: Show sub test provider toggle state in main testing module #30019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30009
What I did
Muted the disabled options and adds a (disabled) suffix:
While I was implementing this, I noticed a discrepancy in the color between the muted option and the description text above ("Starting..."). This prompted me to review what color variable was being used. I found a bunch of places where
barTextColor
was being used whiletextMutedColor
is more appropriate (because it's not in a bar and the intent is muted text) so I've corrected those places as well.Note that the color difference between
defaultText
andtextMutedColor
is pretty minimal, but I've verified these are the exact colors used in Figma.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Here's my summary of the PR changes:
Improves visual feedback for disabled test providers and standardizes muted text colors across the UI components in Storybook's testing module.
(disabled)
suffix and muted text color for disabled test options incode/addons/test/src/components/TestProviderRender.tsx
barTextColor
withtextMutedColor
in multiple components for better semantic meaning and consistencyItemTitle
styled component to handle disabled state stylingListItem
component to use theme'stextMutedColor
directly instead of transparentized text