Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Support v15.1.1 #30068

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 15, 2024

Closes #

What I did

Added support for the upcoming Next.js v15.1 release

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B 1.53 0%
initSize 136 MB 136 MB 0 B 1.53 0%
diffSize 58.4 MB 58.4 MB 0 B 1.53 0%
buildSize 7.24 MB 7.24 MB 0 B 1.22 0%
buildSbAddonsSize 1.88 MB 1.88 MB 0 B 1.22 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B 1.11 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.93 MB 3.93 MB 0 B 1.22 0%
buildPreviewSize 3.3 MB 3.3 MB 0 B 1.2 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.9s 7.2s 336ms -0.85 4.6%
generateTime 21.5s 19.4s -2s -93ms -0.69 -10.8%
initTime 14.6s 14.5s -147ms 0.09 -1%
buildTime 8.8s 8s -750ms -0.91 -9.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.2s 5.1s 891ms 0.01 17.2%
devManagerResponsive 3.3s 4s 685ms 0.32 17%
devManagerHeaderVisible 500ms 618ms 118ms 0.3 19.1%
devManagerIndexVisible 529ms 657ms 128ms 0.15 19.5%
devStoryVisibleUncached 1.7s 1.9s 259ms 0.79 13.1%
devStoryVisible 528ms 656ms 128ms 0.13 19.5%
devAutodocsVisible 497ms 578ms 81ms 0.72 14%
devMDXVisible 456ms 574ms 118ms 0.33 20.6%
buildManagerHeaderVisible 520ms 625ms 105ms 0.21 16.8%
buildManagerIndexVisible 593ms 719ms 126ms 0.16 17.5%
buildStoryVisible 468ms 585ms 117ms 0.28 20%
buildAutodocsVisible 404ms 573ms 169ms 1.17 29.5%
buildMDXVisible 391ms 509ms 118ms 0.53 23.2%

Greptile Summary

Updates the AppRouterProvider component in Next.js and experimental-nextjs-vite frameworks to support Next.js v15.2 while maintaining backward compatibility.

  • Added newLazyCacheNode object for caching in both frameworks
  • Added parentTree and parentCacheNode properties to LayoutRouterContext.Provider for v15.2 support
  • Maintained backward compatibility with childNodes and tree properties for Next.js < v15.2
  • Added TODO comments to mark code for removal when dropping support for older Next.js versions

@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. bug labels Dec 15, 2024
@valentinpalkovic valentinpalkovic changed the title Next.js: Support v15.2 Next.js: Support v15.1 Dec 15, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic force-pushed the valentin/support-nextjs-15.2 branch from 2269119 to 986b602 Compare December 15, 2024 10:21
Copy link

nx-cloud bot commented Dec 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa46d28. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many -t build --parallel=3

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic changed the title Next.js: Support v15.1 Next.js: Support v15.1.1 Dec 15, 2024
@valentinpalkovic valentinpalkovic force-pushed the valentin/support-nextjs-15.2 branch from 986b602 to fa46d28 Compare December 15, 2024 10:42
@valentinpalkovic valentinpalkovic merged commit 302c65c into next Dec 16, 2024
104 of 108 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/support-nextjs-15.2 branch December 16, 2024 09:18
@yannbf yannbf added the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. needs qa Indicates that this needs manual QA during the upcoming minor/major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants