Remove integration tests #3052
Merged
Remove integration tests #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
reviewed
Feb 22, 2018
| command: yarn test --integration | ||
| - store_artifacts: | ||
| path: integration/__image_snapshots__ | ||
| destination: integration_image_snapshots |
There was a problem hiding this comment.
You can try to remove "Workaround for puppeteer/puppeteer#290" step above as well
There was a problem hiding this comment.
And the corresponding script file: https://github.com/storybooks/storybook/blob/da23479536ad8e42d23dac0178cf8ff22f8be2d5/scripts/workaround-puppeteer-issue-290.sh
Codecov Report
@@ Coverage Diff @@
## master #3052 +/- ##
=======================================
Coverage 36.87% 36.87%
=======================================
Files 417 417
Lines 9849 9849
Branches 839 824 -15
=======================================
Hits 3632 3632
- Misses 5732 5774 +42
+ Partials 485 443 -42
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Integration tests have been replaced with Chromatic tests
What I did
Got rid of them
How to test
Make sure build passes.