Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links addon examples #3070

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Fix links addon examples #3070

merged 1 commit into from
Feb 24, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: Examples for links addon are broken

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks documentation labels Feb 24, 2018
Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other examples are broken too

@Hypnosphi
Copy link
Member Author

I think other examples are broken too

How? Why?

@igor-dv
Copy link
Member

igor-dv commented Feb 24, 2018

After I've separated all the examples in the other apps, I didn't check if links are working 😓 So probably they are not.

@Hypnosphi
Copy link
Member Author

Can you check it then?

@igor-dv
Copy link
Member

igor-dv commented Feb 24, 2018

Yep, tomorrow though.

@Hypnosphi Hypnosphi merged commit 0c17736 into master Feb 24, 2018
@Hypnosphi Hypnosphi deleted the fix-links-example branch February 24, 2018 17:19
@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #3070 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3070   +/-   ##
======================================
  Coverage    35.6%   35.6%           
======================================
  Files         420     420           
  Lines        9889    9889           
  Branches      826     829    +3     
======================================
  Hits         3521    3521           
- Misses       5906    5909    +3     
+ Partials      462     459    -3
Impacted Files Coverage Δ
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 22.41% <0%> (ø) ⬆️
addons/info/src/components/Story.js 88.03% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 84.25% <0%> (ø) ⬆️
lib/core/src/client/manager/provider.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/decycle.js 53.52% <0%> (ø) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed8c21...a4d7bb1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants