Cleanup dependencies #3082
Merged
Cleanup dependencies #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3082 +/- ##
==========================================
+ Coverage 35.6% 36.08% +0.48%
==========================================
Files 420 438 +18
Lines 9889 9447 -442
Branches 818 882 +64
==========================================
- Hits 3521 3409 -112
+ Misses 5878 5472 -406
- Partials 490 566 +76
Continue to review full report at Codecov.
|
Hypnosphi
added
dependencies
addon: info
addon: options
ui
addon: storyshots
maintenance
igor-dv
approved these changes
Feb 25, 2018
| @@ -1,110 +0,0 @@ | |||
| import loadBabelConfig from './babel_config'; | |||
There was a problem hiding this comment.
Can you explain please the babel changes? Like why don't we need these tests?
There was a problem hiding this comment.
The only thing it tested, originally, was the addition of babel-plugin-react-docgen which is useless in non-react codebase
| "enzyme": "^3.3.0", | ||
| "enzyme-adapter-react-16": "^1.1.0", | ||
| "enzyme-to-json": "^3.3.1", | ||
| "jest": "^22.4.2", | ||
| "jest": "^20.0.4", |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
— Removed unused dependencies
— Added missing ones
— Removed React-specific stuff from other frameworks apps
— Added
babel-runtimein CLI templates. We usetransform-runtimeon users' code, that means that they need to havebabel-runtimepackage on their sidehttps://depcheck--storybooks.netlify.com/
https://depcheck--storybooks-official.netlify.com/
https://depcheck--storybooks-angular.netlify.com/
https://depcheck--storybooks-cra.netlify.com/
https://depcheck--storybooks-polymer.netlify.com/
https://depcheck--storybooks-vue.netlify.com/