viewport-addon: Add support for adding new viewports/devices #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is my first open-source PR.
Issue: Currently you cannot customize or add new viewports/devices as described in the README file
What I did
viewportaddon to thecra-kitchen-sinkexampleHow to test
cd examples/cra-kitchen-sinkyarn storybookviewportpanel is addedviewports.jsonfile locaed under.storybookIs this testable with jest or storyshots?
Yes
Does this need a new example in the kitchen sink apps?
No, I added it to the
cra-kitchen-sinkalreadyDoes this need an update to the documentation?
Yes, but once the PR is reviewed
If your answer is yes to any of these, please make sure to include it in your PR.