Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADDONS_SUPPORT.md #3114

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Update ADDONS_SUPPORT.md #3114

merged 1 commit into from
Feb 28, 2018

Conversation

getsetbro
Copy link
Contributor

The viewport plugin works in angular.

Issue:

What I did

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

The viewport plugin works in angular.
@codecov
Copy link

codecov bot commented Feb 28, 2018

Codecov Report

Merging #3114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3114   +/-   ##
=======================================
  Coverage   36.08%   36.08%           
=======================================
  Files         438      438           
  Lines        9447     9447           
  Branches      887      894    +7     
=======================================
  Hits         3409     3409           
+ Misses       5475     5468    -7     
- Partials      563      570    +7
Impacted Files Coverage Δ
addons/actions/src/lib/util/getPropertiesList.js 60% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
.../src/modules/ui/components/stories_panel/header.js 29.62% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/addon_panel/index.js 34.78% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 76.92% <0%> (ø) ⬆️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
addons/viewport/src/components/SelectViewport.js 15% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5171450...b9340eb. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@igor-dv igor-dv merged commit 40d1c37 into storybookjs:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants