-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storyshots renderer and serializer options #3252
Fix storyshots renderer and serializer options #3252
Conversation
a4869c3
to
b41ffb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #3252 +/- ##
=======================================
Coverage 35.86% 35.86%
=======================================
Files 440 440
Lines 9682 9682
Branches 909 899 -10
=======================================
Hits 3472 3472
- Misses 5621 5628 +7
+ Partials 589 582 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you! 🎉 |
Fix storyshots renderer and serializer options
What I did
Fixed passthrough of options from
initStoryshots
tosnapshotWithOptions
. In practice, this makes it possible to sendrenderer
andserializer
as options in the intended way (as documented in storyshots' README).How to test
I've updated the snapshots from
storyshot.enzyme.test.js
which uses a custom renderer (enzyme'smount
) and serializer (enzyme-to-json
).Edit: CI is red due to some kind of versioning errors. I don't know what causes that, since my branch is not behind master. I'll be happy to fix it if someone points me in the right direction :)