-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon info prop options #3428
Addon info prop options #3428
Conversation
Tests/snapshots will pass but were broken with latest merge from master. Due to #3427 . |
I'm not sure how to tag the PR as was requested. I don't have permission to add a label. |
@danielduan please remove note about tags from PR template, this is confusing |
Can you please add a prop with large object to addon info example in official-storybook |
@Hypnosphi, definitely. Good idea. |
Codecov Report
@@ Coverage Diff @@
## master #3428 +/- ##
==========================================
+ Coverage 36.74% 36.89% +0.15%
==========================================
Files 459 459
Lines 10144 10167 +23
Branches 886 889 +3
==========================================
+ Hits 3727 3751 +24
+ Misses 5911 5879 -32
- Partials 506 537 +31
Continue to review full report at Codecov.
|
In looking at this again, I noticed that truncated prop ellipses weren't broken to the next line. The latest push corrects this and adds the test @Hypnosphi suggested. |
Released as |
Issue:
Previously,
maxPropsIntoLine
had no effect onobject
orarray
props, potentially resulting in very long lines in the story source. Now,maxPropsIntoLine
affects these in the same way as props, including the correct indentation for each key/value.