Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize boolean type only for non-nullable values #3432

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

mshaaban088
Copy link
Contributor

Issue: #3400

What I did

Serialized boolean type only for non-nullable values

How to test

Is this testable with Jest or Chromatic screenshots?
No

Does this need a new example in the kitchen sink apps?
No

Does this need an update to the documentation?
No

If your answer is yes to any of these, please make sure to include it in your PR.

For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@Hypnosphi Hypnosphi added bug addon: knobs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 16, 2018
@Hypnosphi Hypnosphi merged commit 0f344ba into storybookjs:master Apr 16, 2018
@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #3432 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3432   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files         463      463           
  Lines       10219    10219           
  Branches      924      936   +12     
=======================================
  Hits         3787     3787           
+ Misses       5891     5862   -29     
- Partials      541      570   +29
Impacted Files Coverage Δ
addons/knobs/src/components/types/Boolean.js 11.62% <100%> (ø) ⬆️
addons/storysource/src/loader/traverse-helpers.js 60.86% <0%> (ø) ⬆️
addons/storysource/src/loader/parsers/index.js 44.44% <0%> (ø) ⬆️
addons/viewport/src/manager/components/Panel.js 37.26% <0%> (ø) ⬆️
.../ui/components/stories_panel/stories_tree/index.js 40% <0%> (ø) ⬆️
addons/actions/src/lib/types/function/index.js 77.77% <0%> (ø) ⬆️
addons/info/src/components/types/PropertyLabel.js 78.94% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503c186...2a13294. Read the comment docs.

@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 17, 2018
Hypnosphi added a commit that referenced this pull request Apr 17, 2018
Serialize boolean type only for non-nullable values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants