Add lit-html support #3433
Merged
Add lit-html support #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnkoopal
requested review from
alexandrebodin,
alterx,
Hypnosphi,
igor-dv,
leonrodenburg,
naipath,
ndelangen and
theinterned
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3433 +/- ##
==========================================
+ Coverage 37.2% 37.21% +<.01%
==========================================
Files 463 463
Lines 10242 10241 -1
Branches 894 935 +41
==========================================
Hits 3811 3811
+ Misses 5901 5865 -36
- Partials 530 565 +35
Continue to review full report at Codecov.
|
igor-dv
reviewed
Apr 17, 2018
| @@ -53,12 +53,14 @@ | |||
| "webpack-hot-middleware": "^2.22.0" | |||
| }, | |||
| "devDependencies": { | |||
| "lit-html": "^0.9.0", | |||
There was a problem hiding this comment.
Why do you need the "lit-html" and "polymer-webpack-loader" in devDeps ?
There was a problem hiding this comment.
For lit-html, it's probably because you need a single instance of that package for instanceof TemplateResult to pass
Hypnosphi
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to render a story based on lit-html
What I did
Instead of returning either a
stringor aNodefrom a story, now you can also return aTemplateResultHow to test
See polymer stories in the examples dir