-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme-ability progress #3572
Merged
Merged
Theme-ability progress #3572
Changes from 53 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
e51b713
MOVE & REFACTOR addon-panels to lib/component & glamorous
ndelangen 16c257e
MOVE & REFACTOR layout component to lib/components & style using glam…
ndelangen 0fa6a51
MOVE header to lib/component & REFACTOR to use glamorous && ADD glamo…
ndelangen 4aa547b
UPGRADE glamorous
ndelangen 67935e7
IMPROVE styling of storysource
ndelangen 3b461e2
IMRPOVE scrolling behavior
ndelangen 5f131ca
IMPROVE scrolling of storysource
ndelangen d7fe462
FIX a minor alignment issue
ndelangen f417484
REFACTOR StoriesPanel to use glamorous && CHANGE mobile layout so pre…
ndelangen 22f412e
REFACTOR searchbox & shortcutshelp & treeheader to use glamorous && A…
ndelangen a5f3cd5
REMOVE babel-plugin-glamorous-displayname from test and prod (has a b…
ndelangen 0ee32b3
FIX snapshots not updating even when passing in --update
ndelangen c7b8d59
CHANGE ui for easier themeing
ndelangen 7dd7426
FIX proptype warning
ndelangen ecdb576
REFACTOR preview wrapper to use glamorous
ndelangen fe39ac8
FIX tests && FIX snapshots
ndelangen c710cb9
CLEANUP previous mobile nav
ndelangen 9d7d724
REFACTOR mobile layout to use glamorous
ndelangen 21bc78f
FIX typo
ndelangen fb3c3fc
ADD a placeholder component & use it at places where a 'this is empty…
ndelangen 88fedce
CHANGE styling of shortcuthelp component
ndelangen d0426ba
FIX snapshots
ndelangen e0e77b6
ADD 'jest-glamor-react' to get more meaningful snapshots
ndelangen 60e37f9
FIX babelrc environments
ndelangen 5aee773
REMOVE dist from test-coverage
ndelangen adf9ad7
FIX PropTable & Table/Td/Th
ndelangen ea7be29
RENAME RoutedLink & MenuLink
ndelangen 96f130f
CLEANUP
ndelangen 679da71
Update storyshots
Hypnosphi 7559374
REFACTOR to use emotion, see: https://github.com/paypal/glamorous/iss…
ndelangen 2876570
Merge branch 'feature/more-components' of github.com:storybooks/story…
ndelangen 30a9899
FIX snapshots
ndelangen 35049e2
Merge branch 'master' into feature/more-components
ndelangen 086b74c
FIX linting
ndelangen 5c974a9
FIX padding
ndelangen 5eec2c8
FIX styling issue in storysource addon && CLEANUP && ADD emotion-theming
ndelangen d28d788
REFACTOR knobs to use emotion for styling
ndelangen 359f12c
Merge branch 'master' into feature/more-components
ndelangen 3b517a7
REFACTOR notes to use emotion for styling
ndelangen 09e3d8e
REFACTOR viewport addon to use emotion for styling && FIX overflow of…
ndelangen c6b2b6c
Merge branch 'master' into feature/more-components
ndelangen 9b01c75
REFACTOR a11y addon to use emotion for styling
ndelangen 4002f50
REFACTOR background addon to use emotion for styling
ndelangen 6783d9b
REFACTOR event addon to use emotion for styling
ndelangen de48f96
FIX snaphots & tests & linting
ndelangen e86936c
IMPROVE desktop layout
ndelangen 5b10805
FIX double-escaping
ndelangen 3925f5a
CHANGE package.json files so they are sorted nicely
ndelangen d69c0d8
REFACTOR to use emotion for Logger.js
ndelangen 903d6b1
FIX snapshots
ndelangen d33d53b
REFACTOR addon viewport story to use emotion for styling
ndelangen aec2521
Merge branch 'master' into feature/more-components
ndelangen 7d971b8
FIX snapshots
ndelangen 43279a3
Merge branch 'master' into feature/more-components
ndelangen 552a01c
FIX review comments
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
{ | ||
"presets": ["env", "stage-0", "react"], | ||
"plugins": [ | ||
"babel-plugin-macros", | ||
["transform-runtime", { | ||
"polyfill": false, | ||
"regenerator": true | ||
}] | ||
] | ||
"env": { | ||
"plugins": [ | ||
"emotion", | ||
"babel-plugin-macros", | ||
["transform-runtime", { | ||
"polyfill": false, | ||
"regenerator": true | ||
}] | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is entirely based on code only: Is there a specific reason why the
li
element is styled instead of theol
? The previous implementation had thestyles.element
injected into both of them which looked redundant, so removing one of them is great. But functionality wise it doesn't seem like there's a difference between putting it on theli
andol
. Readability wise this looks better, but is there any possible downside (performance/verbose output for DOM of the user) for not doing so or any explicit reason to do so? Mostly questions out of curiosity!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the
li
actually has user-agent styling applied to it, theol
doesn't as much.