-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't scroll story on knob change #3639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
- Coverage 39.99% 39.98% -0.01%
==========================================
Files 481 481
Lines 5248 5249 +1
Branches 862 863 +1
==========================================
Hits 2099 2099
Misses 2631 2631
- Partials 518 519 +1
Continue to review full report at Codecov.
|
Released as |
I don't know if this change is what caused it, but now I'm seeing the page scroll to the bottom (in fact, all scrollable elements on the page get scrolled to the bottom/to the right) when changing a knob. From your code change it doesn't seem like it would be related, but perhaps the reason the code was there was to offset this behavior? |
I can't reproduce it in our official examples, can you? |
I can't either |
Hmm. I did some testing to figure out what's different on my end and it looks like it's the addon-a11y decorator, which is running each re-render and causing everything to scroll. Has something changed about it recently? I've had the addon since I started this storybook and it's only recently started doing this. (There is also a significant performance hit associated with axe running each time you change a knob -- ah, just found #3683) |
Issue: When changing knobs, example is scrolled to top