Force render on knob button click and update example #3650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: As discussed on Slack, the callback of the button knob didn't seem to do something. What actually happened was that clicking the button didn't trigger a re-render, so the results of the callback were never visually visible.
There was an example in the official-storybook, but that basically used the knob button inside a react component defined in the stories file and triggered a
setState
call to force a render of the component itself. The example itself described that this was not the best way to do this.What I did
cc @ndelangen as he was part of the discussion