Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies(vue): Update vue-loader to 15.x.x #3911

Merged
merged 1 commit into from
Jul 24, 2018
Merged

dependencies(vue): Update vue-loader to 15.x.x #3911

merged 1 commit into from
Jul 24, 2018

Conversation

pksunkara
Copy link
Member

Fixes #3509, #3492

@pksunkara pksunkara changed the title update(vue): Update vue-loader to 15.x.x dependencies(vue): Update vue-loader to 15.x.x Jul 22, 2018
@codecov
Copy link

codecov bot commented Jul 22, 2018

Codecov Report

Merging #3911 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3911      +/-   ##
==========================================
- Coverage   41.56%   41.55%   -0.01%     
==========================================
  Files         455      455              
  Lines        5178     5179       +1     
  Branches      899      899              
==========================================
  Hits         2152     2152              
- Misses       2486     2487       +1     
  Partials      540      540
Impacted Files Coverage Δ
app/vue/src/server/wrapInitialConfig.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1577bb7...a9e57ef. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks a reasonable change, since we are preparing a breaking version of Storybook.

Any reason why the visual tests could fail, though?

image

@pksunkara
Copy link
Member Author

I don't have any idea on why that is. I didn't dig deep because it was just a <h1> style change. Maybe the browser in chromatic changed. Do you want me to find out why this is happening?

@pksunkara
Copy link
Member Author

pksunkara commented Jul 23, 2018

Actually, found out why this is happening. You can see h1 having font-weight: normal at https://github.com/storybooks/storybook/blob/83d55c23fa124fa87cd061bdb5b5ce9453b393c1/examples/vue-kitchen-sink/src/App.vue#L43-L45 But before this PR, this wasn't being used by the component Welcome. The font-weight: bold from the user-agent was being used.

So, I guess, this PR kinda fixes the behaviour now.

@igor-dv
Copy link
Member

igor-dv commented Jul 23, 2018

I don't understand how changing the vue-loader version fixes this

@pksunkara
Copy link
Member Author

@igor-dv
Copy link
Member

igor-dv commented Jul 23, 2018

Ah, thanks, got it.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@storybooks/team, speak now or forever hold your peace

@ndelangen
Copy link
Member

Absolutely perfect!

@ndelangen ndelangen merged commit a57b65b into storybookjs:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants