Support different extensions for "config" and "addons" files #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3913 +/- ##
==========================================
- Coverage 41.55% 39.61% -1.94%
==========================================
Files 455 431 -24
Lines 5179 5452 +273
Branches 899 741 -158
==========================================
+ Hits 2152 2160 +8
- Misses 2487 2910 +423
+ Partials 540 382 -158
Continue to review full report at Codecov.
|
igor-dv
requested review from
dangreenisrael,
danielduan,
theinterned,
usulpro and
z4o4z
as code owners
|
I have a strange issue with this test:
I've committed the snapshot but now it's failing in CircleCI only 🤷♂️ I am not sure why it's failed in the beginning though... Anyone with Mac/Linux can try my branch + run the tests? |
|
I'll check it out |
pksunkara
reviewed
Jul 24, 2018
lib/core/src/server/config.js
Outdated
| @@ -2,8 +2,8 @@ import findCacheDir from 'find-cache-dir'; | |||
| import { logger } from '@storybook/node-logger'; | |||
| import { createDefaultWebpackConfig } from './config/defaults/webpack.config'; | |||
| import devBabelConfig from './config/babel'; | |||
| import loadBabelConfig from './babel_config'; | |||
| import loadCustomConfig from './loadCustomWebpackConfig'; | |||
| import loadBabelConfig from './loadCustomBabelConfig'; | |||
There was a problem hiding this comment.
Why not name this import loadCustomBabelConfig from './loadCustomBabelConfig';
|
its's green now... Dafuq merge from master did? |
|
@igor-dv apply additional magic |
ndelangen
approved these changes
Jul 25, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3737
What I did
When one uses TS (not only, though), she will probably prefer using
.tsin all of the files in a codebase.Currently, we are forcing people to use
config.jsandaddons.jsto configure their stuff.I've used the same approach as in #3785 to fix this.
Notice, I've needed to wrap
.tstransformer in jest to the following pattern:in order to support
require.contextin TS with Jest 🤕