-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon: Added google analytics #4138
Conversation
Generated by 🚫 dangerJS |
addons/google-analytics/README.md
Outdated
Then, set an environment variable | ||
|
||
``` | ||
STORYBOOK_GA_ID = UA-000000-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a global variable?
Might want to make that explicit:
window.STORYBOOK_GA_ID = UA-000000-01;
So I don't think we want this in any example we have.. since really I don't fancy getting into tracking people who browser our examples. So maybe add some unit test for this? |
Maybe a separate |
Awesome work, is this addon nearly finished? |
Need some docs work and tests. |
I actually think the code is simple enough to not have any tests tbh. Let's add some documentation and merge, so we can announce this with 4.0.0 @pksunkara |
1e5b562
to
82615b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4138 +/- ##
==========================================
- Coverage 36.07% 36.02% -0.06%
==========================================
Files 556 557 +1
Lines 6633 6643 +10
Branches 868 869 +1
==========================================
Hits 2393 2393
- Misses 3796 3805 +9
- Partials 444 445 +1
Continue to review full report at Codecov.
|
@ndelangen This PR is ready to go. |
It should be added in https://github.com/storybooks/storybook/blob/master/ADDONS_SUPPORT.md |
Fixes #3944
This PR adds a google analytics addon. This is not ready to be merged. Just a call for review for now.
TODO