Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add height and overflow fixes to addon panel styles #4304

Merged
merged 3 commits into from
Oct 13, 2018
Merged

add height and overflow fixes to addon panel styles #4304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
711611d
add height and overflow fixes to addon panel styles
jonmilner Oct 5, 2018
ea90cf6
Merge branch 'master' into master
Hypnosphi Oct 12, 2018
0b5e131
Merge branch 'master' into master
Hypnosphi Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions addons/a11y/src/components/Panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ const Violations = styled.span(({ theme }) => ({
color: theme.failColor,
}));

const PanelWrapper = styled.div({
height: '100%',
overflow: 'auto',
width: '100%',
});

class Panel extends Component {
static propTypes = {
active: PropTypes.bool.isRequired,
Expand Down Expand Up @@ -78,7 +84,7 @@ class Panel extends Component {
const { active } = this.props;

return active ? (
<div>
<PanelWrapper>
<Tabs
tabs={[
{
Expand All @@ -94,7 +100,7 @@ class Panel extends Component {
<ActionBar>
<ActionButton onClick={this.requestCheck}>RERUN TEST</ActionButton>
</ActionBar>
</div>
</PanelWrapper>
) : null;
}
}
Expand Down
2 changes: 1 addition & 1 deletion addons/actions/src/components/ActionLogger/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ export const Wrapper = styled.div({
flex: 1,
display: 'flex',
position: 'relative',
minHeight: '100%',
height: '100%',
});
2 changes: 2 additions & 0 deletions addons/knobs/src/components/Panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ const getTimestamp = () => +new Date();
const DEFAULT_GROUP_ID = 'ALL';

const PanelWrapper = styled.div({
height: '100%',
overflow: 'auto',
width: '100%',
});

Expand Down
2 changes: 2 additions & 0 deletions addons/viewport/src/manager/components/Panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ const Container = styled.div({
padding: 15,
width: '100%',
boxSizing: 'border-box',
height: '100%',
overflow: 'auto',
});
Container.displayName = 'Container';

Expand Down