Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --debug-webpack option #6082

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Add --debug-webpack option #6082

merged 2 commits into from
Mar 16, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 14, 2019

Issue: #6081

What I did

--debug-webpack prints out both the final manager and preview webpack configs to help people debug their webpack configuration

NOTE: Though this is technically a feature request, I propose that we patch it into 5.0.x and 4.1.x to help people migrate their webpack configs.

How to test

cd examples/official-storybook
yarn storybook --debug-webpack
yarn build-storybook --debug-webpack

@shilman shilman added feature request configuration babel / webpack patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 14, 2019
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #6082 into next will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6082      +/-   ##
==========================================
- Coverage   37.11%   37.05%   -0.06%     
==========================================
  Files         648      649       +1     
  Lines        9523     9536      +13     
  Branches     1352     1385      +33     
==========================================
  Hits         3534     3534              
- Misses       5410     5419       +9     
- Partials      579      583       +4
Impacted Files Coverage Δ
lib/core/src/server/cli/dev.js 0% <ø> (ø) ⬆️
lib/core/src/server/cli/prod.js 0% <ø> (ø) ⬆️
lib/core/src/server/build-static.js 0% <0%> (ø) ⬆️
lib/core/src/server/dev-server.js 0% <0%> (ø) ⬆️
lib/core/src/server/logConfig.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997af33...18d243e. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this is so useful!!

@shilman shilman merged commit d79a371 into next Mar 16, 2019
@shilman shilman deleted the 6081-debug-webpack-option branch March 16, 2019 05:39
@shilman shilman added this to the 5.0.x milestone Mar 16, 2019
shilman added a commit that referenced this pull request Mar 16, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration babel / webpack feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants