Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a11y): update highlight toggle snapshot #6300

Closed
wants to merge 1 commit into from
Closed

chore(a11y): update highlight toggle snapshot #6300

wants to merge 1 commit into from

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 26, 2019

🤷‍♂️

@Armanio Armanio requested review from CodeByAlex and removed request for jbovenschen March 26, 2019 21:38
@shilman shilman added addon: a11y maintenance User-facing maintenance tasks labels Mar 26, 2019
@CodeByAlex
Copy link
Member

@Armanio it looks like it failed on that snapshot. Is there a reason why this is being changed?

@Armanio
Copy link
Member Author

Armanio commented Mar 27, 2019

I just ran tests with --update param. :)

@Armanio
Copy link
Member Author

Armanio commented Mar 27, 2019

  ● HighlightToggle component › should match snapshot

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot "HighlightToggle component should match snapshot 1".

    - Snapshot
    + Received

    @@ -137,11 +137,10 @@
                "appBorderRadius": 4,
                "background": Object {
                  "app": "#F6F9FC",
                  "bar": "#FFFFFF",
                  "content": "#FFFFFF",
    -             "gridCellSize": 10,
                  "hoverable": "rgba(0,0,0,.05)",
                  "negative": "#FEDED2",
                  "positive": "#E1FFD4",
                  "warning": "#FFF5CF",
                },

      36 | 
      37 |     // then
    > 38 |     expect(wrapper).toMatchSnapshot();
         |                     ^
      39 |   });

Currenct next branch failing on tests. 🤔

@shilman
Copy link
Member

shilman commented Mar 27, 2019

Hmm @Armanio this doesn't need to be updated on my machine, and I don't think it's failing on CI either. Can you double check?

@Armanio
Copy link
Member Author

Armanio commented Mar 27, 2019

I checked: pulled actual src, ran tests, it failed.
Ran with 'update' param - update file.
🤔

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing in CI ... ?

@Armanio
Copy link
Member Author

Armanio commented Apr 13, 2019

Already irrelevant. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: a11y maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants