-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle loading .storybook/babel.config.js
(#6633)
#6634
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo.storybook.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix! Did you test it?
@ndelangen are there any good places to drop in tests for this?
@LukeAskew Would you be able to see what we can do to fix the failing cli test? |
Sure, but I could use a little guidance.
|
AFAIR, The similar fix was already considered some time ago. One problem is that it might be a breaking change. SB could start requiring babel configs from root, that are existing in the project and where not required before. Also some discussion was here - #2582 |
Updated the code to just handle module.exports = require('../babel.config'); |
.storybook/babel.config.js
(#6633)
#6633