FIX 6864 - improve the loading of babel config #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen as JSON, and use whichever works
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-babel-config-loading-js.storybook.now.sh |
lydell
reviewed
Jun 5, 2019
| We tried both loading as JS & JSON, neither worked. | ||
| Maybe there's a syntax error in the file?`); | ||
| logger.error(`=> From JS loading we got: ${error.js.message}`); | ||
| logger.error(`=> From JSON loading we got: ${error.js.message}`); |
There was a problem hiding this comment.
This line should say error.json.message, shouldn’t it?
There was a problem hiding this comment.
good catch! any chance you can create a small PR to fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6864
What I did
CHANGE load-custom-babel-config file so it will try to load as JS & then as JSON, and use whichever works