Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links that are not working with plain left click #6970

Merged
merged 5 commits into from
Jun 6, 2019

Conversation

lonyele
Copy link
Member

@lonyele lonyele commented Jun 4, 2019

Issue: #6955

What I did

Problem

Link from @storybook/components/src/typography is used without cancel={false} thus it is not clickable with plain left click. go to code

Places where these are happening from #6955 and not yet reported placeholder.stories.tsx and about.js

Implementation

I added properties cancel={false} and secondary to all the links that are expected to work with the plain left click.

Question

@ndelangen I don't fully understand about this cancel click functionalities but I feel like fixing is needed on link.stories.tsx story from line 15 and 25 is the same. cancel is defaulted to true but I'm not super sure. Please guide me on what to do.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@vercel
Copy link

vercel bot commented Jun 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-notes-tab-link.storybook.now.sh

@ndelangen ndelangen self-assigned this Jun 6, 2019
# Conflicts:
#	lib/ui/src/settings/__snapshots__/about.stories.storyshot
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @lonyele!

@shilman shilman added this to the 5.1.x milestone Jun 6, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 6, 2019
@shilman shilman merged commit e9b8a6a into storybookjs:next Jun 6, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 6, 2019
shilman added a commit that referenced this pull request Jun 6, 2019
Fix links that are not working with plain left click
@lonyele
Copy link
Member Author

lonyele commented Jun 8, 2019

@ndelangen Hi, it is a newbie question...(actually I am) Why was snapshot changed?

@ndelangen
Copy link
Member

Hey @lonyele we have stories for lots of UI bits that make up storybook, some of those UI bits/components use the component you changed.

All our stories are 'tested'/change-detected using jest snapshots & chromatic.

The jest-snapshots have to be updated as part of the code-change; chromatic is approved from a web-ui.

I hope this explains the process to you. Let me know if you want to learn more 👍

@lonyele
Copy link
Member Author

lonyele commented Jun 13, 2019

@ndelangen Thanks for your explanation! I wasn't sure about the changes of hover,active etc but come to think of it, I changed the Link. 👍

@lonyele lonyele deleted the fix/notes-tab-link branch July 19, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants