-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links that are not working with plain left click #6970
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-notes-tab-link.storybook.now.sh |
# Conflicts: # lib/ui/src/settings/__snapshots__/about.stories.storyshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @lonyele!
Fix links that are not working with plain left click
@ndelangen Hi, it is a newbie question...(actually I am) Why was snapshot changed? |
Hey @lonyele we have stories for lots of UI bits that make up storybook, some of those UI bits/components use the component you changed. All our stories are 'tested'/change-detected using jest snapshots & chromatic. The jest-snapshots have to be updated as part of the code-change; chromatic is approved from a web-ui. I hope this explains the process to you. Let me know if you want to learn more 👍 |
@ndelangen Thanks for your explanation! I wasn't sure about the changes of |
Issue: #6955
What I did
Problem
Link
from@storybook/components/src/typography
is used withoutcancel={false}
thus it is not clickable with plain left click. go to codePlaces where these are happening from #6955 and not yet reported
placeholder.stories.tsx
andabout.js
Implementation
I added properties
cancel={false}
andsecondary
to all the links that are expected to work with the plain left click.Question
@ndelangen I don't fully understand about this cancel click functionalities but I feel like fixing is needed on
link.stories.tsx
story from line 15 and 25 is the same. cancel is defaulted to true but I'm not super sure. Please guide me on what to do.How to test