Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate user's babel config #6987

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Don't mutate user's babel config #6987

merged 1 commit into from
Jun 6, 2019

Conversation

Hypnosphi
Copy link
Member

In my case, it leads to errors because I use my own babel-loader

In my case, it leads to errors because I use my own babel-loader
@Hypnosphi Hypnosphi added bug configuration babel / webpack patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Jun 5, 2019
@vercel
Copy link

vercel bot commented Jun 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-hypnosphi-patch-1.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shilman shilman merged commit 477f990 into next Jun 6, 2019
@Hypnosphi Hypnosphi deleted the Hypnosphi-patch-1 branch June 6, 2019 02:31
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 6, 2019
shilman added a commit that referenced this pull request Jun 6, 2019
Don't mutate user's babel config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants