Don't redefine process variable

[Hypnosphi]

Issue: by default, webpack injects process/browser import whenever process global variable is used. Our DefinePlugin overrides it which breaks packages that use stuff like process.cwd(). One example is unified package used by react-markdown internally.

Honestly, I don't remember why I had to add this line which were later copypasted to other places. Anyway, GraphQL addon seems to work OK after my current changes.

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-dont-redefine-process.storybook.now.sh

[tmeasday]

There is another (recently merged?) PR that was fixing this: #6946?

This solution seems better to me however

[Hypnosphi]

There is another (recently merged?) PR that was fixing this: #6946?

It only adds browser field, while there's a lot more in https://github.com/defunctzombie/node-process/blob/master/browser.js

[tmeasday]

This solution seems better to me however

🤷‍♂

[shilman]

I was just blindly copy-pasting a fix from another PR. As long as this doesn't break things, I agree this is much cleaner. Any good way to test this?

[Hypnosphi]

Any good way to test this?

Open https://monorepo-git-dont-redefine-process.storybook.now.sh/examples/official-storybook/?path=/graphql/addons-graphql--get-pickachu and see that it works

[shilman]

Ok, I'm not sure exactly what that proves, but I'll take your word for it 😘

That proves that browser is set to true?

[Hypnosphi]

@shilman No, this proves that defining the whole process variable on our side isn't really needed. That becomes the responsibility of default webpack behavior.

[Hypnosphi]

The compiled code for process usage looks roughly like this, you can check it yourself in develomment, in vendors file:

/* WEBPACK VAR INJECTION */(function(process) {
  <...>
/* WEBPACK VAR INJECTION */}.call(this, __webpack_require__("../../node_modules/process/browser.js")))

And process/browser.js of course defines the browser field among others: https://github.com/defunctzombie/node-process/blob/master/browser.js#L156

[cloud-walker]

I use react-markdown and I've upgraded storybook to v5.1 and part of my stories are like this right now:

[Hypnosphi]

@cloud-walker yeah, that's exactly the issue this PR fixes