Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for all devServer options #711

Closed
wants to merge 5 commits into from
Closed

add support for all devServer options #711

wants to merge 5 commits into from

Conversation

thabti
Copy link

@thabti thabti commented Mar 5, 2017

Webpack chunks details can be too noises, allowing users to pass additional options to disable noise.

example webpack file:

// you can use this file to add your custom webpack plugins, loaders and anything you like.
// This is just the basic way to add addional webpack configurations.
// For more information refer the docs: https://getstorybook.io/docs/configurations/custom-webpack-config

// IMPORTANT
// When you add this file, we won't add the default configurations which is similar
// to "React Create App". This only has babel loader to load JavaScript.
const package = require('../package.json');
const webpack = require('webpack');
module.exports = {
  plugins: [
    // your custom plugins
    new webpack.NoErrorsPlugin()
  ],
  devServer: {
    stats: 'errors-only',
  },
  module: {
    loaders: [
  
      {
        test: /\.js$/, loader: "eslint-loader", exclude: /node_modules/
      },
      {
        test: /\.css|.scss$/,
        loader: `style!css?modules&importLoaders=2&sourceMap&localIdentName=${package.config.cssModulePattern}!sass?outputStyle=expanded&sourceMap`
      }
    ],
  },
};

Will stop this noise:
screen shot 2017-03-05 at 1 35 12 pm

Webpack chunks details can be too noises, allowing users to pass additional options to disable noise.
@einarlove
Copy link

Similar to this open PR #697, but I think both options could we useful.

The --quiet option suggested also silences the output in the console in the browser.

@ndelangen ndelangen self-assigned this Mar 28, 2017
@ndelangen
Copy link
Member

Hey @sabeurthabti, do you think you could resolve the conflicts?

@thabti
Copy link
Author

thabti commented Apr 12, 2017

@ndelangen I think there is no need for this PR anymore. Someone already passed the config. devServer. Happy for this to be closed.

@ndelangen
Copy link
Member

@sabeurthabti Thanks anyway !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants