Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular-cli: Add addon-docs example #7257

Merged
merged 4 commits into from
Jul 5, 2019
Merged

Angular-cli: Add addon-docs example #7257

merged 4 commits into from
Jul 5, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 2, 2019 •
edited
Loading

Issue: #6664

What I did

  • Add DocsPage to existing angular-cli stories
  • Add addon-docs MDX example to angular-cli
  • Add placeholder angular presets/lib in addon-docs

How to test

cd examples/angular-cli
yarn storybook

@shilman shilman added maintenance User-facing maintenance tasks angular addon: docs labels Jul 2, 2019
@shilman shilman added this to the 5.2.0 milestone Jul 2, 2019
@vercel
Copy link

vercel bot commented Jul 2, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-6664-angular-docs-page.storybook.now.sh

@shilman shilman requested review from CodeByAlex and ndelangen July 2, 2019 16:00
@shilman shilman mentioned this pull request Jul 2, 2019
Closed
6 tasks
@shilman shilman mentioned this pull request Jul 2, 2019
Closed
21 tasks
@shilman shilman merged commit 4aa3a71 into next Jul 5, 2019
@shilman shilman deleted the 6664-angular-docs-page branch July 5, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@CodeByAlex CodeByAlex Awaiting requested review from CodeByAlex

Assignees
No one assigned
Labels
addon: docs angular maintenance User-facing maintenance tasks
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @ndelangen