Fix bug where Sidebar input refreshed on 'Enter' #7342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-rembrandtreyes-7244-sidebar-refresh.storybook.now.sh |
rembrandtreyes
requested review from
igor-dv,
ndelangen,
shilman and
tmeasday
as code owners
shilman
added
bug
ui
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jul 31, 2019
Fix bug where Sidebar input refreshed on 'Enter'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7244
What I did
The sidebar search input would refresh when a user hits "Enter". I prevented the form from submitting by passing in a
.preventDefault()throughonSubmiton the Form level.How to test
If your answer is yes to any of these, please make sure to include it in your PR.