-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jest redesign #7395
Closed
Closed
Feature/jest redesign #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…similar to the accessibility addon for a more cohesive experience
…o add color to the expected and received values
Removed console log
…/storybook into feature/jest-redesign
…unction that returns an object
…s (ex. no longer checking for expected/result/etc.). Made it backwards compatible with previous result format.
…(one included breaks between title and value and the other outputs both in one line)
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-codebyalex-feature-jest-redesign.storybook.now.sh |
…eature/jest-redesign the commit.
CodeByAlex
requested review from
danielduan,
igor-dv,
ndelangen,
renaudtertrais,
tmeasday and
usulpro
as code owners
July 14, 2019 21:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Redesigned and refactored the Jest addon to follow the pattern of the accessibility addon.
Parsing now works with new jest output format as well as the old format.
There is more data coming to this addon but this is just a redesign.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.