Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix MDX source string escaping #7497

Merged
merged 2 commits into from
Jul 20, 2019
Merged

Addon-docs: Fix MDX source string escaping #7497

merged 2 commits into from
Jul 20, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 20, 2019

Issue: N/A

What I did

Use a proper string escaping library. Added a problem test case to official-storybook

@vercel
Copy link

vercel bot commented Jul 20, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-mdx-string-escaping.storybook.now.sh

@shilman shilman added this to the 5.2.0 milestone Jul 20, 2019
@shilman shilman mentioned this pull request Jul 20, 2019
Closed
@shilman shilman requested a review from tmeasday July 20, 2019 03:44
@shilman
Copy link
Member Author

shilman commented Jul 20, 2019

self merging

@shilman shilman merged commit 9c94171 into next Jul 20, 2019
@shilman shilman deleted the fix/mdx-string-escaping branch July 20, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduan danielduan Awaiting requested review from danielduan

@usulpro usulpro Awaiting requested review from usulpro

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
addon: docs bug
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman