Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-loader: separate server and client code #7510

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

Hypnosphi
Copy link
Member

Issue: 5.2.0-beta doesn't work in IE11. The reason is that client code is transpiled to node target, see https://github.com/storybookjs/storybook/pull/7117/files#r305589980

What I did

Separated server and client code so that they are transpiled to respective targets

@vercel
Copy link

vercel bot commented Jul 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman added this to the 5.2.0 milestone Jul 21, 2019
@shilman shilman merged commit 8a21f97 into next Jul 21, 2019
@shilman shilman deleted the source-loader-separate-server-client branch July 21, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants