-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Allow linking to kind/component ID #7648
Merged
shilman
merged 10 commits into
storybookjs:next
from
lonyele:feature/existing-story-default-route
Oct 24, 2019
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ee71fe0
feat: add default route when child is not specified on existing story
lonyele 2e3503d
feat: add test and fix regression test
lonyele 17c7343
Merge branch 'next' of https://github.com/storybookjs/storybook into …
lonyele 20f3b50
feat: improve finding leaf story from any given depth
lonyele 00383df
fix: failing regression tests
lonyele 58b1413
chore: remove unnecessary logic
lonyele bbbc212
test: add more story items to the storiesHash
lonyele 86753c5
test: add test cases of different depth
lonyele 76c92c8
Merge branch 'next' into pr/lonyele/7648
ndelangen 68ee7ce
Merge branch 'next' into pr/7648
shilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lonyele
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman oh wait, I'm writing a test now. BTW, this comment is on the previous file change. Please refresh for the new one