-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add @types/webpack-env to apps that depend on it, fixes #8110 #8119
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-react-types.storybook.now.sh |
@hipstersmoothie @kroeder Do we need to add these to all the other frameworks as well? |
Yeah I think if we need to add this to 1 package, we need to add them to all that have typescript in them. |
Will do tomorrow!
…On Mon, Sep 23, 2019 at 6:32 PM Norbert de Langen ***@***.***> wrote:
Yeah I think if we need to add this to 1 package, we need to add them to
all that have typescript in them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8119?email_source=notifications&email_token=AAJDEBALKPSCV7KOQS7NTUTQLFU4JA5CNFSM4IYEBOSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MYJFY#issuecomment-534348951>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJDEBHDWKLSGBE5SDOB32LQLFU4JANCNFSM4IYEBOSA>
.
|
Thank you! Really really appreciated! |
e458782
to
766be97
Compare
@ndelangen I added the types dep to all |
@hipstersmoothie mind fixing the linting error?
|
766be97
to
f1aba7e
Compare
Issue: fixes #8110
What I did
add webpack-env types to react, they are needed for the build
How to test
If your answer is yes to any of these, please make sure to include it in your PR.