Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/webpack-env to apps that depend on it, fixes #8110 #8119

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

hipstersmoothie
Copy link
Contributor

Issue: fixes #8110

What I did

add webpack-env types to react, they are needed for the build

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@hipstersmoothie hipstersmoothie added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 18, 2019
@vercel
Copy link

vercel bot commented Sep 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-react-types.storybook.now.sh

@shilman
Copy link
Member

shilman commented Sep 19, 2019

@hipstersmoothie @kroeder Do we need to add these to all the other frameworks as well?

@ndelangen
Copy link
Member

Yeah I think if we need to add this to 1 package, we need to add them to all that have typescript in them.

@hipstersmoothie
Copy link
Contributor Author

hipstersmoothie commented Sep 24, 2019 via email

@ndelangen
Copy link
Member

Thank you! Really really appreciated!

@vercel vercel bot temporarily deployed to staging September 24, 2019 15:54 Inactive
@hipstersmoothie hipstersmoothie changed the title fix: add missing type def to react fixes #8110 fix: add @types/webpack-env to apps that depend on it, fixes #8110 Sep 24, 2019
@hipstersmoothie
Copy link
Contributor Author

@ndelangen I added the types dep to all apps that had it in their tsconfig

@shilman
Copy link
Member

shilman commented Sep 25, 2019

@hipstersmoothie mind fixing the linting error?

/tmp/storybook/app/preact/src/client/preview/render.tsx
3:1 error 'common-tags' should be listed in the project's dependencies. Run 'npm i -S common-tags' to add it import/no-extraneous-dependencies

app/preact/package.json Show resolved Hide resolved
@ndelangen ndelangen merged commit 932ce6f into next Sep 25, 2019
@ndelangen ndelangen deleted the react-types branch September 25, 2019 16:51
@shilman shilman added this to the 5.2.x milestone Oct 7, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 7, 2019
shilman pushed a commit that referenced this pull request Oct 7, 2019
fix: add @types/webpack-env to apps that depend on it, fixes #8110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript build fail when removing @types/storybook__react
3 participants