-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom themes breaking the welcome demo. #8259
Conversation
Having applied a dark theme to storybook I noticed that the react demo sets the background white but does not set the text color. This resulted in white text (from my custom theme) rendered on a white background. This change will make the text readable
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-qazzian-patch-2.storybook.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for the fix!!!
@Qazzian mind updating the snapshots?
|
I've run the tests locally and I'm not getting any errors with the snapshots. I've followed the contribution guide for setting up my dev environment, and tried a second time after running a reset. This is the summary I get after running
|
So I've fixed the snapshots. |
Thanks for taking care of that @Qazzian!! |
Fix custom themes breaking the welcome demo.
Having applied a dark theme to storybook I noticed that the react demo sets the background white but does not set the text color. This resulted in white text (from my custom theme) rendered on a white background. This change will make the text readable
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.