Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom themes breaking the welcome demo. #8259

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Conversation

Qazzian
Copy link
Contributor

@Qazzian Qazzian commented Oct 1, 2019

Having applied a dark theme to storybook I noticed that the react demo sets the background white but does not set the text color. This resulted in white text (from my custom theme) rendered on a white background. This change will make the text readable

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Having applied a dark theme to storybook I noticed that the react demo sets the background white but does not set the text color. This resulted in white text (from my custom theme) rendered on a white background. This change will make the text readable
@vercel
Copy link

vercel bot commented Oct 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-qazzian-patch-2.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the fix!!!

@shilman
Copy link
Member

shilman commented Oct 1, 2019

@Qazzian mind updating the snapshots?

yarn test --core --update

@Qazzian
Copy link
Contributor Author

Qazzian commented Oct 2, 2019

I've run the tests locally and I'm not getting any errors with the snapshots.
running yarn test --core --update doesn't change the snapshots.

I've followed the contribution guide for setting up my dev environment, and tried a second time after running a reset.

This is the summary I get after running yarn test

Test Suites: 109 passed, 109 total
Tests:       901 passed, 901 total
Snapshots:   277 passed, 277 total
Time:        247.199s
Ran all test suites in 8 projects.

@Qazzian
Copy link
Contributor Author

Qazzian commented Oct 14, 2019

So I've fixed the snapshots.
The only thing that's blocking the merge now is automention.
Is there anything I need to do to help this?

@shilman
Copy link
Member

shilman commented Oct 15, 2019

Thanks for taking care of that @Qazzian!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants