Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: Migrate @storybook/mithril #8320

Merged
merged 5 commits into from
Oct 18, 2019
Merged

Typescript: Migrate @storybook/mithril #8320

merged 5 commits into from
Oct 18, 2019

Conversation

hcz
Copy link
Member

@hcz hcz commented Oct 7, 2019

Issue: #5030

What I did

Migrate @storybook/mithril to Typescript

How to test

Everything should function the same, except the package should now have type definitions.

@vercel
Copy link

vercel bot commented Oct 7, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/cr26p5zgs
🌍 Preview: https://storybookjs.now.sh

@vercel vercel bot temporarily deployed to staging October 7, 2019 23:48 Inactive
@hcz
Copy link
Member Author

hcz commented Oct 9, 2019

@shilman What should I do more? Some checks were failed

@shilman shilman added the maintenance User-facing maintenance tasks label Oct 9, 2019
@shilman
Copy link
Member

shilman commented Oct 9, 2019

@hcz Looks good -- I just added an extra label! I think one of our typescript posse should review & then we can merge.

@ndelangen ndelangen self-assigned this Oct 17, 2019
@ndelangen ndelangen added this to the 5.3.0 milestone Oct 17, 2019
ndelangen
ndelangen requested changes Oct 17, 2019
View reviewed changes
app/mithril/package.json Outdated Show resolved Hide resolved
@hcz hcz requested a review from renaudtertrais as a code owner October 17, 2019 17:16
@ndelangen
Copy link
Member

good to merge!

@ndelangen
Copy link
Member

I invited you to the org @hcz !

@shilman shilman changed the title Migrate @storybook/mithril to TypeScript Typescript: Migrate @storybook/mithril Oct 18, 2019
shilman
shilman approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @hcz !!! 🚀

@shilman shilman merged commit 11697a8 into storybookjs:next Oct 18, 2019
@shilman shilman mentioned this pull request Oct 19, 2019
Closed
@davidroman0O
Copy link

davidroman0O commented Nov 22, 2019 •
edited
Loading

I know it's merged but anyone have an example of Mithril + TypeScript ?

Or this merge is not yet release? maybe?

I tried to setup one (multiple times) and I still have a lot of errors with esModuleInterop flag and others from simple TypeScript helloworld like components in a yarn monorepo!

@ndelangen
Copy link
Member

@davidroman0O This feature will be released in 5.3 (see milestone)
You can try this today by upgrading to the beta.

We'd love to hear your feedback. A more detailed report of what you tried, and what errors you got would help./

@davidroman0O
Copy link

@ndelangen Oh yeah ! 😄

Thx!

@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman shilman approved these changes

@renaudtertrais renaudtertrais Awaiting requested review from renaudtertrais

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hcz @shilman @ndelangen @davidroman0O