CLI: Add flag to disable version checks #8488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/hquqoself |
…change && IMPROVE types
shilman
reviewed
Oct 20, 2019
shilman
requested changes
Oct 20, 2019
ndelangen
force-pushed
the
tech/versioncheck-overhaul
branch
from
70a77cc to
d49c1aa
Compare
shilman
requested changes
Oct 23, 2019
|
added the test @shilman |
shilman
reviewed
Oct 24, 2019
| @@ -239,5 +239,23 @@ describe('versions API', () => { | |||
|
|
|||
| expect(api.versionUpdateAvailable()).toEqual(true); | |||
| }); | |||
|
|
|||
| it('new prerelease version', async () => { | |||
There was a problem hiding this comment.
Will it work when the user is upgrading from one prerelease to another?
There was a problem hiding this comment.
added code & tests for this
…date when user is on prerelease that's newer
shilman
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6194
What I did
I made it so the version check only happens once in node, so it's less disruptive
I added a CLI flag that disables the feature entirely
How to test
run an example with
--no-version-updates, it should not do the version checkrun an example without
--no-version-updates, it should do the version check