Typescript: add types for react demo #8517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When I use the demo story files generated by the cli, and change the file name from
.stories.js
to.stories.tsx
, the two demo components provided in thereact
package causes the following error.This is because the generated typings for the demo components are not included in the root folder of
react
,@storybook/react/demo
What I did
Added
d.ts
file for demo components in root directory of react.How to test
Adding
d.ts
file in the root directory of react made the error go away, and the auto completion properly worked as expected.files
property inpackage.json
includes*.d.ts
, so thisd.ts
file will be included when user installs the@storybook/react
package.If your answer is yes to any of these, please make sure to include it in your PR.