Increase TooltipLinkList max-height to accommodate more links #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/7xf6o87xu |
shilman
approved these changes
Oct 24, 2019
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Nov 9, 2019
Increase TooltipLinkList max-height to accommodate more links
This was referenced Nov 18, 2019
Merged
[Snyk] Upgrade @storybook/addon-actions from 5.2.5 to 5.2.6
GrabarzUndPartner/gp-vue-boilerplate#308
Merged
Merged
This was referenced Nov 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8509
What I did
Increase the max-height value to accommodate up to 20 items
How to test
cd examples/official-storybook yarn storybookNote
The same hard limit also exists in docs/src/new-components/basics/tooltip/TooltipLinkList.js but it doesn't seem to be used (at least with a fast search in source code) so I didn't touch it