Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-notes: Add key to render function #8633

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Addon-notes: Add key to render function #8633

merged 1 commit into from
Oct 30, 2019

Conversation

jung-han
Copy link
Contributor

Issue: #7005

image

What I did

  • add key to addon-notes register

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps? NO
  • Does this need an update to the documentation? NO

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Oct 30, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/nyfx7o0l9
🌍 Preview: https://monorepo-git-fork-jung-han-7005-addon-notes-key-warning.storybook.now.sh

@jung-han jung-han changed the title fix: add key to render function(#7005) FIX add key to render function(#7005) Oct 30, 2019
@lonyele lonyele self-requested a review October 30, 2019 07:17
@lonyele lonyele added the maintenance User-facing maintenance tasks label Oct 30, 2019
@shilman shilman added addon: notes bug and removed maintenance User-facing maintenance tasks labels Oct 30, 2019
@shilman shilman changed the title FIX add key to render function(#7005) Addon-notes: Add key to render function Oct 30, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 30, 2019
@shilman shilman added this to the 5.2.x milestone Oct 30, 2019
@shilman shilman merged commit 17e422e into storybookjs:next Oct 30, 2019
@shilman shilman mentioned this pull request Oct 30, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 9, 2019
shilman added a commit that referenced this pull request Nov 9, 2019
@shilman
Merge pull request #8633 from jung-han/7005-addon-notes-key-warning
b79d007 
Addon-notes: Add key to render function
This was referenced Nov 18, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 30, 2019
Closed
Closed
Closed
@jung-han jung-han deleted the 7005-addon-notes-key-warning branch July 28, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@lonyele lonyele Awaiting requested review from lonyele

Assignees
No one assigned
Labels
addon: notes bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jung-han @shilman @lonyele