Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React-native: Fix layout in RN61 so addons no longer initially displayed #8681

Merged
merged 2 commits into from
Nov 3, 2019
Merged

React-native: Fix layout in RN61 so addons no longer initially displayed #8681

merged 2 commits into from
Nov 3, 2019

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Nov 2, 2019

Issue: #8613, #8274

What I did

Fixed the layout

@vercel
Copy link

vercel bot commented Nov 2, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/npq984pbj
🌍 Preview: https://monorepo-git-fixing-rn-61.storybook.now.sh

@Gongreg Gongreg requested review from ndelangen and shilman November 2, 2019 20:31
shilman
shilman approved these changes Nov 3, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Fixed layout in react native 61, addons are not initially displayed anymore React-native: Fix layout in RN61 so addons no longer initially displayed Nov 3, 2019
@shilman shilman merged commit c54e0c2 into next Nov 3, 2019
@shilman shilman deleted the fixing-rn-61 branch November 3, 2019 06:21
This was referenced Nov 3, 2019
Closed
Closed
@JeffGuKang JeffGuKang mentioned this pull request Nov 3, 2019
Closed
This was referenced Aug 11, 2020
Closed
Closed
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
This was referenced Aug 28, 2021
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@rmevans9 rmevans9 Awaiting requested review from rmevans9

@tmeasday tmeasday Awaiting requested review from tmeasday

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
bug react-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gongreg @shilman