Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix regression to @ignore in Props #8867

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Conversation

patricklafrance
Copy link
Member

@patricklafrance patricklafrance commented Nov 18, 2019

Issue: #8539

#8857 introduced a regression with @ignore. The ignored prop were returned an undefined.

What I did

Fixed the issue and added a test.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Nov 18, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/mqxcir023
🌍 Preview: https://monorepo-git-fix-jsdoc-ignore.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Fix regression to @ignore introduced by 8857 Addon-docs: Fix regression to @ignore in Props Nov 18, 2019
@shilman shilman merged commit 42326b9 into next Nov 18, 2019
@shilman shilman deleted the fix-jsdoc-ignore branch November 18, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants