Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Increase Props summary and func length #8998

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Addon-docs: Increase Props summary and func length #8998

merged 2 commits into from
Dec 2, 2019

Conversation

patricklafrance
Copy link
Member

Issue: #8997

What I did

  • Summary max length for all types has been increased to 90 characters.
  • Summary max length for func has been increased to 150 characters.
  • Expanded func are not formatted instead of being displayed on a single line.

How to test

Use cra-ts-kitchen-sink

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Nov 28, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/gvznk97oe
🌍 Preview: https://monorepo-git-props-table-increase-max-summary-and-func.storybook.now.sh

shilman
shilman approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title Props table increase max summary and func Addon-docs: Increase Props table increase summary and function length Dec 2, 2019
@shilman shilman changed the title Addon-docs: Increase Props table increase summary and function length Addon-docs: Increase Props summary and function length Dec 2, 2019
@shilman shilman changed the title Addon-docs: Increase Props summary and function length Addon-docs: Increase Props summary and func length Dec 2, 2019
@shilman shilman merged commit 16e08e7 into next Dec 2, 2019
@shilman shilman deleted the props-table-increase-max-summary-and-func branch December 2, 2019 01:07
@shilman shilman mentioned this pull request Dec 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs block: props feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricklafrance @shilman