CSF: Use __namedExportsOrder
array in loader if provided
#9315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9136
follow up of #9181
What I did
As discussed in #9181 there have been 2 solutions to guarantee a story order if loaded via es modules. I went for the object. However, I have been missing the use case of rexports
which currently produces the following
export const __orderedExports = { notMyStory };
which fails asnotMyStory
is not a local variable.Therefore we should go with the previously discussed array of strings.
This Pull Request changes how loaders can guarantee the order of stories
Before:
After:
How to test
Notes
Related PR where we found the issue
open-wc/open-wc#1171